Skip to content

Conversation

@PeterDaveHello
Copy link
Contributor

To speed up and make the repo thinner, easier to manage.

@jackycute
Copy link
Member

Hello, very good to see you done this. I agreed with your point.
But if someone want to use this locally then will be a problem using cdn.
Is there any other choice can make?

@PeterDaveHello
Copy link
Contributor Author

But you are already using cdn, e.g.
https://github.com/jackycute/HackMD/blob/master/public/index.html#L18

So I don't think this is a new issue.

Produce a local version may be a possible solution.

@jackycute
Copy link
Member

Oh my, your totally right, I missed that...
OK, I will merge your PR, thank you very much.

I'm consider using requireJS to do cdn fallback now.

jackycute added a commit that referenced this pull request Jul 2, 2015
@jackycute jackycute merged commit 4d40a10 into hackmdio:master Jul 2, 2015
@PeterDaveHello PeterDaveHello deleted the cdn branch July 2, 2015 03:20
@PeterDaveHello
Copy link
Contributor Author

👍

@jackycute
Copy link
Member

Hello, I might fallback and not using cdn.
Because I found many people like to use this offline and internally, so it's better not use cdn.
Thank you anyway, and we might have a plan to make a standalone app in the future.

@PeterDaveHello
Copy link
Contributor Author

Maybe we can use a config to decide use it or use local files?

@jackycute
Copy link
Member

That's a good idea, I might will try it.

I've research again for cdn fallback, but no good solution for now.
Only can provide a config option to switch resource including templates.
Or use grunt or gulp to pack and compress things up to one might be better.

What do you think?

@PeterDaveHello
Copy link
Contributor Author

I think config is good enough 😄

@jackycute
Copy link
Member

Hey, I've add useCDN option, take a look!

@PeterDaveHello
Copy link
Contributor Author

👍

lamprosfasoulas added a commit to lamprosfasoulas/codimd that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants