Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for nightly fallout #138

Merged
merged 3 commits into from Aug 18, 2014

Conversation

Projects
None yet
3 participants
@farcaller
Copy link
Member

commented Aug 18, 2014

Originally based on #137

bharrisau and others added some commits Aug 18, 2014

@farcaller farcaller added in progress and removed in progress labels Aug 18, 2014

@farcaller farcaller changed the title Fixes nightly fallout Fixes for nightly fallout Aug 18, 2014

@farcaller

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2014

This new Index trait makes code look awful: let ref old = (*map)[*name]; FWIW.

@farcaller

This comment has been minimized.

Copy link
Owner Author

commented on ccc0e63 Aug 18, 2014

r+

@hacknbot

This comment has been minimized.

Copy link
Contributor

commented on ccc0e63 Aug 18, 2014

saw approval from farcaller
at farcaller@ccc0e63

This comment has been minimized.

Copy link
Contributor

replied Aug 18, 2014

merging farcaller/zinc/fix-nightly = ccc0e63 into auto

This comment has been minimized.

Copy link
Contributor

replied Aug 18, 2014

farcaller/zinc/fix-nightly = ccc0e63 merged ok, testing candidate = 2af9fe6

This comment has been minimized.

Copy link
Contributor

replied Aug 18, 2014

This comment has been minimized.

Copy link
Contributor

replied Aug 18, 2014

fast-forwarding master to auto = 2af9fe6

hacknbot added a commit that referenced this pull request Aug 18, 2014

Merge pull request #138 from farcaller/fix-nightly
Fixes for nightly fallout

Reviewed-by: farcaller

@hacknbot hacknbot merged commit ccc0e63 into hackndev:master Aug 18, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details

@farcaller farcaller deleted the farcaller:fix-nightly branch Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.