Skip to content

Conversation

@bigorn0
Copy link
Contributor

@bigorn0 bigorn0 commented Sep 2, 2025

Content

Remove the custom module to use a simple patch that isolate the small changes
Migrate avsc dependency from 5.4.11 to 5.7.9 and update the custom patch to maintain error collection functionality.

Aligns with studio here

Technical details

Changes Made:

  • Dependency Update: Upgraded avsc from 5.4.11 to 5.7.9
  • Patch Migration: Successfully migrated custom patch for error collection functionality
  • Error Handling: Replaced blocking error throws with non-blocking error collection
  • Backward Compatibility: Maintained existing error handling behavior

Key Features Preserved:

  • Non-blocking Validation: Errors are collected rather than thrown immediately
  • Error Aggregation: All validation errors are collected in errorsCollector array
  • Enhanced Debugging: Added field name context to errors for better troubleshooting
  • Schema Flexibility: More permissive validation logic where appropriate

Files Changed:

  • package.json - Updated avsc version
  • package-lock.json - Updated lock file
  • patches/avsc+5.4.11.patch - Removed old patch
  • patches/avsc+5.7.9.patch - Added new patch (3,783 insertions, 477 deletions)

Testing:

  • Verified that all changes are properly applied to the current avsc installation
  • Confirmed Type.addError function and errorsCollector are in place
  • Patch file successfully generated and ready for use with avsc 5.7.9

This migration ensures the plugin continues to work with the latest avsc version while preserving the custom error collection functionality that prevents validation errors from blocking the schema processing workflow.

Plugin build from branch

- Update avsc dependency from 5.4.11 to 5.7.9
- Migrate custom patch for error collection functionality
- Replace throw new Error() calls with Type.addError() for non-blocking validation
- Add errorsCollector array and Type.addError function for error aggregation
- Maintain backward compatibility with existing error handling behavior
- Update package-lock.json to reflect new avsc version

This migration ensures the plugin continues to work with the latest avsc version
while preserving the custom error collection functionality that prevents
validation errors from blocking the schema processing workflow.
@bigorn0 bigorn0 enabled auto-merge (squash) September 2, 2025 08:50
@bigorn0 bigorn0 changed the title feat: migrate from avsc custom module in FE to a patch and update avsc from 5.4.11 to 5.7.9 [HCK-12579]feat: migrate from avsc custom module in FE to a patch and update avsc from 5.4.11 to 5.7.9 Sep 2, 2025
@bigorn0 bigorn0 disabled auto-merge September 2, 2025 12:16
@bigorn0 bigorn0 enabled auto-merge (squash) September 2, 2025 12:36
@bigorn0 bigorn0 disabled auto-merge September 2, 2025 13:17
@bigorn0 bigorn0 enabled auto-merge (squash) September 2, 2025 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

@bigorn0 bigorn0 disabled auto-merge September 2, 2025 14:20
@bigorn0
Copy link
Contributor Author

bigorn0 commented Sep 2, 2025

All tests are ok

@bigorn0 bigorn0 merged commit 3058104 into develop Sep 2, 2025
2 checks passed
@bigorn0 bigorn0 deleted the deps/avsc-align-and-cleanup branch September 2, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants