Skip to content

HCK-13870: script generation options for UK#127

Merged
chulanovskyi-bs merged 4 commits intoHCK-13867from
HCK-13870
Dec 12, 2025
Merged

HCK-13870: script generation options for UK#127
chulanovskyi-bs merged 4 commits intoHCK-13867from
HCK-13870

Conversation

@AlikRakhmonov
Copy link
Contributor

@AlikRakhmonov AlikRakhmonov commented Dec 11, 2025

Sub-taskHCK-13870 [Hive] Enable script generation for UK

Technical details

Script generation options for UK. It's similar to PK logic.

@AlikRakhmonov AlikRakhmonov self-assigned this Dec 11, 2025
@AlikRakhmonov AlikRakhmonov requested review from chulanovskyi-bs and removed request for VitaliiBedletskyi December 11, 2025 15:48
* UNIQUE, NOT NULL, DEFAULT and CHECK constraints are available from DB version 3
*/
const getIsConstraintAvailable = data => {
return !data?.modelData?.[0]?.dbVersion?.startsWith('1') && !data?.modelData?.[0]?.dbVersion?.startsWith('2');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do early exit if there is no data?.modelData?.[0]?.dbVersion? 🙂

@sonarqubecloud
Copy link

@chulanovskyi-bs chulanovskyi-bs merged commit ff8749f into HCK-13867 Dec 12, 2025
1 check passed
@chulanovskyi-bs chulanovskyi-bs deleted the HCK-13870 branch December 12, 2025 09:37
chulanovskyi-bs pushed a commit that referenced this pull request Dec 12, 2025
* HCK-13867: Script generation options for PK

* HCK-13874: script generation options for comments (#126)

* HCK-13874: script generation options for comments

* fix

* fix: var name

* HCK-13870: script generation options for UK (#127)

* HCK-13870: script generation options for UK

* fix version

* fix

* fix

* hotfix: comment shouldn't be in object, it's added later

* fix: constraint names (#128)
chulanovskyi-bs pushed a commit that referenced this pull request Dec 16, 2025
…129)

* HCK-13867: Script generation options for PK

* HCK-13874: script generation options for comments (#126)

* HCK-13874: script generation options for comments

* fix

* fix: var name

* HCK-13870: script generation options for UK (#127)

* HCK-13870: script generation options for UK

* fix version

* fix

* fix

* hotfix: comment shouldn't be in object, it's added later

* fix: constraint names (#128)

* HCK-13871: script generation options for CHECK, DEFAULT and  NOT NULL

* fix

* fix

* fix

* pk is not null

* comment deactivated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants