Skip to content

HCK-15888: MySQL default timestamp with on update #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Apr 24, 2026
Merged

HCK-15888: MySQL default timestamp with on update #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/helpers/columnDefinitionHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@

const decorateDefault = (type, defaultValue) => {
const defaultValuesRegExp =
/^(null|current_timestamp(\(\d+\))?)(\s+on\s+update\s+current_timestamp(\(\d+\))?)?$/i;
/^(null|current_timestamp(\(\d+\))?|'[^']*')(\s+on\s+update\s+current_timestamp(\(\d+\))?)?$/i;

Check warning on line 78 in forward_engineering/helpers/columnDefinitionHelper.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its complexity from 22 to the 20 allowed. 


See more on https://sonarcloud.io/project/issues?id=hackolade_MySQL&issues=AZ2-eMa4RBAoUMXpbi0O&open=AZ2-eMa4RBAoUMXpbi0O&pullRequest=61
if ((isString(type) || isDateTime(type)) && !defaultValuesRegExp.test(_.trim(defaultValue))) {
return wrap(escapeQuotes(defaultValue));
} else {
Expand Down
Loading