Skip to content

Fix/hck 4304 hackolade assignment function definition in pos #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix/hck 4304 hackolade assignment function definition in pos #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
774d98b
FE: allow defining the quantity of estimated rows for udfs that retur…
serhii-filonenko Dec 7, 2023
059d74b
FE: update checking that the function returns a table
serhii-filonenko Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion forward_engineering/ddlProvider/ddlHelpers/functionHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ module.exports = ({ _, templates, assignTemplates, getFunctionArguments, getName
}
};
const getExecutionRows = (value, udf) => {
if (!value || !udf.functionReturnsSetOf) {
if (!value || (!udf.functionReturnsSetOf && !isFunctionReturnsTable(udf))) {
return '';
}

Expand All @@ -84,6 +84,11 @@ module.exports = ({ _, templates, assignTemplates, getFunctionArguments, getName
}
};

const isFunctionReturnsTable = (udf) => {
const returnType = (udf.functionReturnType || '').trim().toUpperCase();
return returnType.startsWith('TABLE');
};

return {
getFunctionsScript,
};
Expand Down
6 changes: 1 addition & 5 deletions properties_pane/container_level/containerLevelConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,7 @@ making sure that you maintain a proper JSON format.
"valueType": "number",
"minValue": 0,
"step": 1,
"propertyTooltip": "A positive number giving the estimated number of rows that the planner should expect the function to return.",
"dependency": {
"key": "functionReturnsSetOf",
"value": true
}
"propertyTooltip": "A positive number giving the estimated number of rows that the planner should expect the function to return."
},
{
"propertyName": "Support function",
Expand Down