Skip to content

Conversation

@janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

CWES is now also assigned to CBBH role

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Right now the API sends the CWES name for newer certs causing new cert holders not being able to verify

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.61%. Comparing base (2a4f491) to head (1fcc4fa).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/verification.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   53.66%   53.61%   -0.05%     
==========================================
  Files          44       44              
  Lines        2482     2488       +6     
==========================================
+ Hits         1332     1334       +2     
- Misses       1150     1154       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janssensjelle
Copy link
Contributor Author

janssensjelle commented Sep 4, 2025

@dimoschi Can we perhaps merge and release this? Some people are experiencing this and the number will grow the more people pass. Similar to #153

@dimoschi dimoschi merged commit bfca6eb into hackthebox:main Sep 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants