Skip to content

Conversation

@pravinthan
Copy link

@pravinthan pravinthan commented Mar 4, 2021

Also changed nested styles -> flat styles

@pravinthan pravinthan requested a review from fpunny March 4, 2021 22:13
@fpunny
Copy link
Member

fpunny commented Mar 4, 2021

Owo did u merge master yet?

@pravinthan
Copy link
Author

I think you merged the branch into master yesterday

@fpunny
Copy link
Member

fpunny commented Mar 4, 2021

I think you merged the branch into master yesterday

hmm kk try merging with the latest master. since there's some little issues with the webpack config that isnt fixed in this branch (which is fixed in current master), and I want to see if it's used in the final merged version

@pravinthan
Copy link
Author

oh you meant merge master into this branch?

@fpunny
Copy link
Member

fpunny commented Mar 4, 2021

oh you meant merge master into this branch?

yup, merge it and if its all good, we can squash merge this back into master

</div>
<div className={imageContainer}></div>
<div className={imageContainer}>
<StaticImage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owo interesting, a staticquery isnt needed anymore

@fpunny
Copy link
Member

fpunny commented Mar 4, 2021

image
owo good stuff - some issues with image size of the png + defining explicit width + height. But we can come back to that later when we polish

@fpunny
Copy link
Member

fpunny commented Mar 4, 2021

image

Copy link
Member

@fpunny fpunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM owo

@fpunny fpunny merged commit cd4ab7c into master Mar 4, 2021
@fpunny fpunny deleted the HTV-2 branch July 16, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants