HTV Factions #16
HTV Factions #16
Conversation
There was a problem hiding this comment.
The animations are a bit rough (Missing transitions going "backwards") but on the right track. Some healthy sprinkles of js might elevate it a bit. Also consider include opacity into the transition so it doesnt seem like it just "pops" into existence.
I would not pay too much attention to it however, animations can come later owo. lets focus on fixing everything else first
|
|
Yeah this looks good now
|
|
Everything looks a lot better now, thanks for the review. Also added the themed colours for the logo (since it's much easier to do when the svg is inline) |
|
|
| { | ||
| health: file(relativePath: { eq: "factions-health.png" }) { | ||
| childImageSharp { | ||
| gatsbyImageData( |
There was a problem hiding this comment.
We can also look into a fragment, but this would do owo
fpunny
left a comment
fpunny
left a comment
There was a problem hiding this comment.
LGTM. Let's roll this out first, and we can touch up later. Thanks :DD
oops opacity cant be % lol |
Added implementation for factions.
Note: In Dev, the pics flicker when the state is changed (for whatever reason). If you run a Prod build, then it's all good.