Dashboard main #32
Merged
Dashboard main #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpunny
reviewed
May 16, 2021
| @@ -0,0 +1,100 @@ | |||
| @use "@htv/ui-kit/styles/colors"; | |||
Member
There was a problem hiding this comment.
Some feedback on the PR as I'm tiding things together
- Good job on being consistent on the tools we have at hand. The linesContainer is a bit of an odd one out, but its understandable given it's nature
fpunny
reviewed
May 16, 2021
| @@ -0,0 +1,68 @@ | |||
| import Text from '@htv/ui-kit/components/Text' | |||
Member
There was a problem hiding this comment.
This is a nice piece, I would however argue that this can be a single component and the only changing factor is the status. Which we can toggle in text and style based on the status enum returned using an object like such
const displayText = {
[enum]: 'OwO wats dis?',
};
...
<Element className={classNames(class, `class__${enum}`)>
{ displayText(enum) }
</Element>
fpunny
reviewed
May 16, 2021
Comment on lines
+62
to
+63
| <div> | ||
| <div> |
Member
There was a problem hiding this comment.
Too many divs, go easy on the elements :p
I would consider looking into css grid as its a really nice way of doing some fairly complicated layouts with minimum amount of elements
fpunny
reviewed
May 16, 2021
| </Card> | ||
| <Card> | ||
| <Text className={questionMarks} lineHeight='normal' align='start' type='heading1'> | ||
| ??? |
Member
There was a problem hiding this comment.
This is something that I wouldn't expect u to pickup, but is very interesting since it would show you how one single element can change everything.
Factions and FAQs are basically the same in terms of layout. Hence, but simply wrapping this ??? in an element - you have the two cards have the same HTML layout - allowing for the CSS to be shared between them consistently.
fpunny
reviewed
May 16, 2021
Member
fpunny
left a comment
fpunny
left a comment
There was a problem hiding this comment.
Overall this PR is a really good, and I can see effort and growth as there are more consistency in this codebase compared to before - where you are using our mixins, vars, components, and unit of measurements appropriately.
You should be proud of this PR as it's a good quality work
fpunny
added a commit
that referenced
this pull request
Oct 22, 2021
* Update index.jsx * owo' * changes * Added folder Login in 'src/sections' along with index.jsx and corresponding empty Login.module.scss * Updated Login page with more styling. * owo * Created border boxes in login form and adjusted sign in button to look clean * Dashboard main (#32) * dashboard implementation (status not completed yet) * margin fix * application status implementation * Added file dropper implementation (#29) * Added file dropper implementation * Removed testing code * added requested changes * Got rid of testing code * Added props for supported file extensions and file input name attribute; Improved error logic so that it will display to the user that they dropped in an invalid file; Added comments to explain the props * owo * Responsive login * owo final polish * uwu * clear auto complete thingy * init application page * Added featureflags and prashant changes * fix build issues (TODO: ssr level routing) * Added proper route filter + 404 * update date * Added sponsor stuff * fixed sponsor hydration styles * removed sponsor type header * Update data.js * Forgot Password Page (#36) * Added forgot password page * text lineheight * Checkbox + Layout for some Application sections (#35) * Added checkbox and added layout for experience section and below * Updated checkbox with better logic, focus css, and styling * using useRef instead of createRef * Added form controls for experience, MLH, and consent sections; Added Required component Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update gatsby-config.js * Update index.jsx * added virtual (#37) * Finished apps (#38) * touched up guards and error handling * lint * Update FormContext.jsx * bug fixes * fix: change factions to routes * fix: More routing fixes * Update index.jsx * Update majors.js * Added forgot password * fix window check * owo * Update schools.js * Update gatsby-config.js * Update index.jsx * Update schools.js * Added rsvp ability * Update index.jsx * Fixed status error * more state changes * Added discord stuff * Update index.jsx * task: Added rsvp feature flag * Update gatsby-config.js * task: fix rsvp toggle * Update gatsby-config.js * fix: Added netlify plugin to gatsby * welp * welp * owo * save me * uwu * Added pinnguaq challenge * Added The Hub logo with conditional rendering (#39) * task: Added schedule * task: Touched up schedule linking * Fixed date/time bug for schedule * removed log * Fixed default val * Update Events.module.scss * Updated Splash for HTV 6 (#41) * Change metadata in preparation for HTV 6 * Edit Splash for pre-registration HTV * Updated dates for HTV * Commented out sponsors card (#42) * Commented out sponsors card * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update about date to Winter 2022 (#45) * Update about date to Winter 2022 * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Updated HTV date in FAQs (#43) * Update HTV date * Update package.json * Update dates based on gatsby-config module * Commented out Pinnguaq/The Hub faction (#44) * Removed Pinnguaq/The Hub faction Commented out data for Pinnguaq/The Hub faction...may have them back? * Update version * Set grid column dynamically using css variables Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> Co-authored-by: coolmanbat2 <thanusun.thayaparan@mail.utoronto.ca> Co-authored-by: Amanda Tang <59590407+AmandaTang849@users.noreply.github.com> Co-authored-by: Pravinthan Prabagaran <pravinthan.prabagaran@gmail.com> Co-authored-by: Manpreet Bhatti <manpreet@bhatti.net>
fpunny
added a commit
that referenced
this pull request
Nov 16, 2021
* Update develop (#46) * Update index.jsx * owo' * changes * Added folder Login in 'src/sections' along with index.jsx and corresponding empty Login.module.scss * Updated Login page with more styling. * owo * Created border boxes in login form and adjusted sign in button to look clean * Dashboard main (#32) * dashboard implementation (status not completed yet) * margin fix * application status implementation * Added file dropper implementation (#29) * Added file dropper implementation * Removed testing code * added requested changes * Got rid of testing code * Added props for supported file extensions and file input name attribute; Improved error logic so that it will display to the user that they dropped in an invalid file; Added comments to explain the props * owo * Responsive login * owo final polish * uwu * clear auto complete thingy * init application page * Added featureflags and prashant changes * fix build issues (TODO: ssr level routing) * Added proper route filter + 404 * update date * Added sponsor stuff * fixed sponsor hydration styles * removed sponsor type header * Update data.js * Forgot Password Page (#36) * Added forgot password page * text lineheight * Checkbox + Layout for some Application sections (#35) * Added checkbox and added layout for experience section and below * Updated checkbox with better logic, focus css, and styling * using useRef instead of createRef * Added form controls for experience, MLH, and consent sections; Added Required component Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update gatsby-config.js * Update index.jsx * added virtual (#37) * Finished apps (#38) * touched up guards and error handling * lint * Update FormContext.jsx * bug fixes * fix: change factions to routes * fix: More routing fixes * Update index.jsx * Update majors.js * Added forgot password * fix window check * owo * Update schools.js * Update gatsby-config.js * Update index.jsx * Update schools.js * Added rsvp ability * Update index.jsx * Fixed status error * more state changes * Added discord stuff * Update index.jsx * task: Added rsvp feature flag * Update gatsby-config.js * task: fix rsvp toggle * Update gatsby-config.js * fix: Added netlify plugin to gatsby * welp * welp * owo * save me * uwu * Added pinnguaq challenge * Added The Hub logo with conditional rendering (#39) * task: Added schedule * task: Touched up schedule linking * Fixed date/time bug for schedule * removed log * Fixed default val * Update Events.module.scss * Updated Splash for HTV 6 (#41) * Change metadata in preparation for HTV 6 * Edit Splash for pre-registration HTV * Updated dates for HTV * Commented out sponsors card (#42) * Commented out sponsors card * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update about date to Winter 2022 (#45) * Update about date to Winter 2022 * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Updated HTV date in FAQs (#43) * Update HTV date * Update package.json * Update dates based on gatsby-config module * Commented out Pinnguaq/The Hub faction (#44) * Removed Pinnguaq/The Hub faction Commented out data for Pinnguaq/The Hub faction...may have them back? * Update version * Set grid column dynamically using css variables Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> Co-authored-by: coolmanbat2 <thanusun.thayaparan@mail.utoronto.ca> Co-authored-by: Amanda Tang <59590407+AmandaTang849@users.noreply.github.com> Co-authored-by: Pravinthan Prabagaran <pravinthan.prabagaran@gmail.com> Co-authored-by: Manpreet Bhatti <manpreet@bhatti.net> * Release sponsors (#47) * Release sponsors * Add feature flag for sponsors * Added featureflag implementation * owo sponsors Co-authored-by: coolmanbat2 <thanusun.thayaparan@mail.utoronto.ca> Co-authored-by: Amanda Tang <59590407+AmandaTang849@users.noreply.github.com> Co-authored-by: Pravinthan Prabagaran <pravinthan.prabagaran@gmail.com> Co-authored-by: Manpreet Bhatti <manpreet@bhatti.net>
fpunny
added a commit
that referenced
this pull request
Nov 23, 2021
* Update develop (#46) * Update index.jsx * owo' * changes * Added folder Login in 'src/sections' along with index.jsx and corresponding empty Login.module.scss * Updated Login page with more styling. * owo * Created border boxes in login form and adjusted sign in button to look clean * Dashboard main (#32) * dashboard implementation (status not completed yet) * margin fix * application status implementation * Added file dropper implementation (#29) * Added file dropper implementation * Removed testing code * added requested changes * Got rid of testing code * Added props for supported file extensions and file input name attribute; Improved error logic so that it will display to the user that they dropped in an invalid file; Added comments to explain the props * owo * Responsive login * owo final polish * uwu * clear auto complete thingy * init application page * Added featureflags and prashant changes * fix build issues (TODO: ssr level routing) * Added proper route filter + 404 * update date * Added sponsor stuff * fixed sponsor hydration styles * removed sponsor type header * Update data.js * Forgot Password Page (#36) * Added forgot password page * text lineheight * Checkbox + Layout for some Application sections (#35) * Added checkbox and added layout for experience section and below * Updated checkbox with better logic, focus css, and styling * using useRef instead of createRef * Added form controls for experience, MLH, and consent sections; Added Required component Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update gatsby-config.js * Update index.jsx * added virtual (#37) * Finished apps (#38) * touched up guards and error handling * lint * Update FormContext.jsx * bug fixes * fix: change factions to routes * fix: More routing fixes * Update index.jsx * Update majors.js * Added forgot password * fix window check * owo * Update schools.js * Update gatsby-config.js * Update index.jsx * Update schools.js * Added rsvp ability * Update index.jsx * Fixed status error * more state changes * Added discord stuff * Update index.jsx * task: Added rsvp feature flag * Update gatsby-config.js * task: fix rsvp toggle * Update gatsby-config.js * fix: Added netlify plugin to gatsby * welp * welp * owo * save me * uwu * Added pinnguaq challenge * Added The Hub logo with conditional rendering (#39) * task: Added schedule * task: Touched up schedule linking * Fixed date/time bug for schedule * removed log * Fixed default val * Update Events.module.scss * Updated Splash for HTV 6 (#41) * Change metadata in preparation for HTV 6 * Edit Splash for pre-registration HTV * Updated dates for HTV * Commented out sponsors card (#42) * Commented out sponsors card * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Update about date to Winter 2022 (#45) * Update about date to Winter 2022 * Update package.json Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> * Updated HTV date in FAQs (#43) * Update HTV date * Update package.json * Update dates based on gatsby-config module * Commented out Pinnguaq/The Hub faction (#44) * Removed Pinnguaq/The Hub faction Commented out data for Pinnguaq/The Hub faction...may have them back? * Update version * Set grid column dynamically using css variables Co-authored-by: Frederic Pun <frederic.pun@mail.utoronto.ca> Co-authored-by: coolmanbat2 <thanusun.thayaparan@mail.utoronto.ca> Co-authored-by: Amanda Tang <59590407+AmandaTang849@users.noreply.github.com> Co-authored-by: Pravinthan Prabagaran <pravinthan.prabagaran@gmail.com> Co-authored-by: Manpreet Bhatti <manpreet@bhatti.net> * Release sponsors (#47) * Release sponsors * Add feature flag for sponsors * Added featureflag implementation * owo sponsors * owo forms stuff * fix form misorder Co-authored-by: coolmanbat2 <thanusun.thayaparan@mail.utoronto.ca> Co-authored-by: Amanda Tang <59590407+AmandaTang849@users.noreply.github.com> Co-authored-by: Pravinthan Prabagaran <pravinthan.prabagaran@gmail.com> Co-authored-by: Manpreet Bhatti <manpreet@bhatti.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.