Program to explain functions in JS#380
Merged
t2013anurag merged 3 commits intohacktoberfest17:masterfrom Oct 18, 2017
shubham0109:functions_in_JS
Merged
Program to explain functions in JS#380t2013anurag merged 3 commits intohacktoberfest17:masterfrom shubham0109:functions_in_JS
t2013anurag merged 3 commits intohacktoberfest17:masterfrom
shubham0109:functions_in_JS
Conversation
t2013anurag
requested changes
Oct 17, 2017
| @@ -0,0 +1,18 @@ | |||
| <html> | |||
Contributor
There was a problem hiding this comment.
move the file to functions directory, and rename the file to functions_in_js.html.
Contributor
Author
There was a problem hiding this comment.
@t2013anurag I guess there's no functions directory right now. Do you want me to create a functions directory and push the JS file into it?
| @@ -0,0 +1,57 @@ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
move the file to functions directory, and rename the file to functions_in_js_main.html.
| } | ||
| var rupees = convertToINR(dollars); // Here the dollars refer to the global dollar variable, although inside the function | ||
| // it is changed locally | ||
| // outside the val of dollars is still 15 No newline at end of file |
|
|
||
| </body> | ||
|
|
||
| </html> No newline at end of file |
| <body> | ||
| <h1> | ||
| FUNCTIONS IN JS | ||
| </h1> |
Contributor
There was a problem hiding this comment.
remove all extra lines from the code
Contributor
Author
There was a problem hiding this comment.
@t2013anurag Here are you suggesting to remove all the white spaces or should I shorten my code?
Contributor
There was a problem hiding this comment.
remove extra new lines., use only one return statement in code.
t2013anurag
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #30