Skip to content

Conversation

@YosefAshenafi
Copy link
Contributor

Status

Ready

Description

  • Fixed theme issue where it now reverts to the system default when ignoreSystemMode is turned off.
  • Make the statubar unchanged when ignoreSystemMode is turned off

componentDefaults?: Record<ModifiableComponent, Record<string, any>>;
}

// Utility function to handle color scheme setting logic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving the comment right above the if statement or removing it since the function is self-explanatory

Copy link
Contributor

@shreyastelkar shreyastelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jontsai jontsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@jontsai jontsai merged commit f73d0c6 into hacktoolkit:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants