feat: auto-open install walkthrough on mobile browsers instead of toast - #144
Merged
Conversation
Co-Authored-By: Caleb Bae <baecal000@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Caleb Bae <baecal000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all the install onboarding toasts.
InstallPromptHostnow opens theInstallGuideDialogwalkthrough automatically for any logged-in user on a phone browser (platform === "ios" | "android") that isn't running standalone — on every visit, not just the first (the dialog's open state is derived, not gated by theinstall-promptedlocalStorage flag):Closing the dialog still
dismiss()es (settles the onboarding step so push/schedule-tip aren't blocked). On desktop there is nothing to install, so the step is settled immediately via an effect. The nativebeforeinstallpromptInstall action is gone along with the toasts;promptInstall/canPromptNativelyremain available inuseInstallPrompt.Also drops the
min-h-72/mt-autofrom the "Get Notified" push dialog so there is no empty gap between the description and the buttons.Link to Devin session: https://app.devin.ai/sessions/3819fb8e090243e3be94e42b6634f587
Open in Devin Desktop: https://app.devin.ai/desktop/session/3819fb8e090243e3be94e42b6634f587?variant=devin
Requested by: @balebbae