-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/add scans #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/add scans #30
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
77310f1
feat(db): add scans table and scan type settings migrations
balebbae ca65af8
feat(store): add scans store, types, and settings methods
balebbae b221351
feat(api): add scan handlers, tests, and fix route prefixes
balebbae 2362e3e
docs(api): add swagger annotations to scan handlers
balebbae 7ef5444
feat: o(1) scan stats, for future FE polling
balebbae 814fb8b
chore: clean up
balebbae 22738cf
chore: go fmt issues
balebbae 1c1943e
chore: go static check issues
balebbae bfb94b8
refactor: GetEmailsByStatus returns UserEmailInfo with user_id and fi…
balebbae 8090d41
chore: add back swagger header
balebbae a747b41
chore: remove unneeded index
balebbae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same questions about the first line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally remove the first line of the headers:
Examples:
// getOrCreateApplicationHandler returns the user's application, creating a draft if none exists
// updateApplicationHandler updates the user's draft application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh yeah I feel like the swagger descriptions pretty self explanatory already. Also I don't like when comments restate the function. Lowkey claudes faults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait claudes smarter than me... Apparently it's needed . I'll go add them again.