Consolidate admin/assigned and admin/completed UI#57
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the admin “Assigned” and “Completed” review pages to share a common layout component, consolidating duplicated page scaffolding and introducing in-page navigation between the two review views.
Changes:
- Introduce a new shared
ReviewsPageLayoutused by both Assigned and Completed pages. - Update
AssignedPageandCompletedPageto render viaReviewsPageLayoutprops (header/table/detail panel). - Remove the “Completed” item from the main admin sidebar navigation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client/web/src/pages/admin/completed/CompletedPage.tsx | Switches to shared ReviewsPageLayout wrapper for consistent header/table/detail composition. |
| client/web/src/pages/admin/assigned/AssignedPage.tsx | Switches to shared ReviewsPageLayout, moving header UI into layout props. |
| client/web/src/pages/admin/_shared/ReviewsPageLayout.tsx | New shared layout providing header (incl. Assigned/Completed tabs), table container, and detail panel slot. |
| client/web/src/pages/admin/_shared/index.ts | Re-exports ReviewsPageLayout for cleaner imports. |
| client/web/src/pages/admin/_shared/AppSidebar.tsx | Removes the sidebar “Completed” nav entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| detailPanel, | ||
| }: ReviewsPageLayoutProps) { | ||
| const location = useLocation(); | ||
| const isAssigned = location.pathname === "/admin/assigned"; |
There was a problem hiding this comment.
now that i think about this, this prob isnt the cleanest way to do this, ima change it up rq
There was a problem hiding this comment.
made better in most recent commit
| @@ -38,11 +37,6 @@ const applicantsNav = [ | |||
| url: "/admin/assigned", | |||
| icon: UserCheck, | |||
| }, | |||
|
|
now i think about it, on the assigned page there are 3 mentions that you are on the assigned page which is kinda funny but dumb, but i dont know what to change for that |
|
Maybe rename the left from assigned to reviews? |
|
yeah true. I'll do some clean up with these naming conventions. |
Consolidated the page and removed the Complete area on the side nav menu as it was redundant.