fix: percent-encode track name in expo navigation#328
Merged
MichaelZhao21 merged 2 commits intohackutd:masterfrom Apr 30, 2026
Merged
fix: percent-encode track name in expo navigation#328MichaelZhao21 merged 2 commits intohackutd:masterfrom
MichaelZhao21 merged 2 commits intohackutd:masterfrom
Conversation
The expo dropdown built the track URL with `t.replace(/\s/g, '%20')`, which only escapes spaces. A track name containing a slash (e.g. "AI/ML") got navigated to /expo/AI/ML, which the route /expo/:track interpreted as nested path segments and failed to match. Use encodeURIComponent so spaces, slashes, and any other reserved URL characters survive round-tripping through React Router.
MichaelZhao21
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The expo dropdown built the track URL with
t.replace(/\s/g, '%20'), which only escapes spaces. A track name containing a slash (e.g. "AI/ML") got navigated to /expo/AI/ML, which the route /expo/:track interpreted as nested path segments and failed to match. Use encodeURIComponent so spaces, slashes, and any other reserved URL characters survive round-tripping through React Router.Fixes #315
Type of Change
Delete options that do not apply:
Is this a breaking change?