Conversation
Introduce a GeometryService implementation for designer interactions and migrate code to use document/screen/local coordinate APIs. Update core types (PageGeometrySnapshot, LocalCoordinateOptions) and replace direct UnitManager screen<->document usage across designer composables, interactions, and material editors. Add geometry-service implementation and tests, adjust architecture docs and table-kernel to use document coordinates, and add an ESLint rule to forbid direct unitManager conversions in interaction code. This centralizes page offset/scroll/zoom handling and node transforms through a single service.
Introduce a writingMode prop (horizontal|vertical) for the text material and wire it through schema, defaults and AI descriptor. Refactor rendering logic into a new rendering.ts with helpers (getTextContainerStyles, getTextContentStyles) used by both designer and viewer, and export the module from index.ts. Update prop schemas, locale strings and mcp-server materials config to reflect the new enum and remove the legacy richText property; viewer now always escapes content (legacy richText treated as plain/escaped), and a unit test was added to verify vertical-mode styling and richText escaping.
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (74)
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.