Adds new integration [Big-Xan/adaptive_plant]#6520
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
frenck
left a comment
There was a problem hiding this comment.
Hi @Big-Xan, thanks for the submission! 👋
One blocker before merge:
Sort position. The line "Big-Xan/adaptive_plant" is placed between "BigPiloto/ha-drugstore-stock" and "binarydev/ha-generac", but in the case-insensitive ASCII sort that HACS uses, the hyphen in big-xan (codepoint 0x2D) sorts before letters like n (0x6E) and p (0x70). After the big prefix matches, your repo's next character is -, which makes it sort before both bignocciolino and bigpiloto. Please move the line so it sits between "bieniu/ha-perplexity" and "BigNocciolino/CryptoTracker".
Push the fix to the existing branch and CI will re-run automatically.
A couple of non-blocking notes for a future release:
www/adaptive-plant-card.jsat the repo root is not shipped via HACS for an integration submission (HACS only copiescustom_components/<domain>/). If you want users to receive the card automatically, move it insidecustom_components/adaptive_plant/frontend/and serve it viahass.http.async_register_static_paths, registering the Lovelace resource inasync_setup_entry. There's a clean reference for this pattern in #6517 (eladnahum5/ha-vouchervault).- Same for
blueprints/automation/at the repo root. If you want HACS users to get the example blueprints, embed them undercustom_components/adaptive_plant/blueprints/and copy them intohass.config.path("blueprints")on setup via the executor with an mtime guard. Reference: #6514 (dn5qMDW3/tzevaadom).
../Frenck
Blogging my personal ramblings at frenck.devFix sort position for Big-Xan/adaptive_plant
|
Hi Frenck, thanks for the detailed review and all that you do for HA and HACS! I've fixed the sort position — Big-Xan/adaptive_plant is now placed between bieniu/ha-perplexity and BigNocciolino/CryptoTracker. CI is passing. I've noted the two non-blocking points about the frontend card and blueprints — I'll tackle both in a follow-up release once the integration is listed. Thank you so much for the tips :) Marking as ready for review. Thanks again! |
Checklist
Links
Link to current release: https://github.com/Big-Xan/adaptive_plant/releases/tag/v1.0.7
Link to successful HACS action (without the
ignorekey): https://github.com/Big-Xan/adaptive_plant/actions/runs/23520327795Link to successful hassfest action (if integration): https://github.com/Big-Xan/adaptive_plant/actions/runs/23520256820