feat(manifestos): seed quality+testing manifestos for forge-loop itself (dogfood)

[hadamrd]

Parent

Part of #130.

What

Write the seed manifestos for forge-loop itself, informed by THIS week's iteration-probe bugs (#97/#120/#128) + the persistent-worker work. These are the dogfood manifestos — every future forge-loop change is gated by them.

Acceptance

.forge/quality-manifesto.md rules (with rationale):

• No shared mutable module-level state. Use a Container or per-instance State. (refactor(runner): Runner class + RunnerState (closes #87) #100 Runner class)
• Every external I/O boundary lives behind a typed Protocol with a Fake for tests. (refactor(adapters): Protocol-typed git/fs/clock + Container DI (closes #86) #104 adapters)
• Single config source of truth via Settings. No os.environ.get outside settings.py. (refactor(config): single pydantic-settings model (closes #84) #98)
• Typed events for every state change. No untyped **fields for kinds that have a registered model. (refactor(events): typed event framework (closes #88) #99)
• No subprocess.run for SDK-able external services. (refactor(roles): critic + PO migrate to Claude Agent SDK (closes #85) #103 critic SDK, refactor(gh): typed GhClient + githubkit (framework for #83) #105 GhClient)

.forge/testing-manifesto.md rules:

• State machine ⇒ ONE TEST PER EDGE + ONE fallthrough adversarial test per default-branch. (Would have caught fix(runner): quarantine undeletable worktree dirs (#96) #97/fix(iteration): bail on CLOSED PR + fetch before ahead-count #120/hot-fix(iteration): probe misclassification + escalate label-removal #128.)
• External-dep assumption ⇒ ONE adversarial test for the false case. (origin/ exists? gh CLI alive? file readable?)
• subprocess.returncode handling ⇒ test BOTH ==0 and !=0 branches. (hot-fix(iteration): probe misclassification + escalate label-removal #128 specifically.)
• Every Protocol Fake ⇒ a regression test that asserts the Real impl returns the same shape on representative inputs.
• Property-based tests on any function with >4 branches OR any function consuming user input. (test(property): hypothesis property tests + caught real fingerprint bug (closes #91) #102 hypothesis caught the fingerprint surrogate crash.)
• Every infinite-loop guard ⇒ adversarial test that the guard actually fires.

Test plan

• pytest tests/test_manifestos_discovery.py finds + parses both new files
• Critic on the manifesto PR itself uses the manifestos (meta-validation)

[hadamrd]

forge-loop attempt — ✅ MERGED (~544s)

PR: #139

fingerprint: c0a0d97e7e92

{
  "ts": "2026-05-28T17:12:10+00:00",
  "status": "merged",
  "pr_url": "https://github.com/hadamrd/forge-loop/pull/139",
  "duration_s": 543.6,
  "note": "",
  "event_count": 0,
  "brief_fingerprint": "c0a0d97e7e923a78e866c502033a3c26b8873f464f653c256059a0ac1383cc0a"
}