feat(manifestos): discover_manifestos loader + pydantic schema (#131)#143
Merged
Conversation
Adds the issue #131 discovery API alongside the existing #132 worker-prompt injection API in forge_loop.manifestos: * QualityManifesto / TestingManifesto / Manifestos pydantic models * Rule model (id, description, severity?) — minimal per the #131 out-of-scope clause * MissingManifestoError exception (mirrors MissingVisionError) * discover_manifestos(repo_path, *, required=False) -> Manifestos Soft-default semantics: missing markdown ⇒ empty manifesto + warning. required=True ⇒ raises MissingManifestoError with absolute path. Malformed *-rules.yaml always raises (silent corruption is worse than absence). Empty markdown is treated as "present but empty" with no warning. Adversarial cases (dangling .forge symlink, .forge as file, markdown-is-a-directory) raise clean MissingManifestoError rather than leaking OSError stacktraces. Test matrix in tests/test_manifestos_discover.py covers every bullet from the acceptance criteria plus the symlink / directory / bare-list adversarials.
Owner
Author
|
Source issue #131 was closed mid-flight (state: closed). Loop refusing auto-merge. Reopen the issue OR merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131.
Summary
Adds
discover_manifestos()and theQualityManifesto/TestingManifesto/Manifestos/Rulepydantic models inforge_loop.manifestos, plus aMissingManifestoErrormodelled onMissingVisionError. Existingload_manifestos/ManifestoBundlesurface (#132 worker-prompt injection) is preserved unchanged — the two APIs share the same files but serve different consumers.Acceptance criteria → coverage
QualityManifesto/TestingManifesto(markdown: str,rules: list[Rule] | None) +Manifestosbundle withquality/testing/warnings.discover_manifestos(repo_path, *, required=False)..forge/quality-manifesto.md+ optional.forge/quality-rules.yaml; same for testing.required=True⇒MissingManifestoErrorwith absolute path.__all__. (ProductVisionis not re-exported fromforge_loop/__init__.py, so neither are these — consistent.)pathlib,pydantic,pyyaml.Adversarial coverage
.forgesymlink → cleanMissingManifestoError, notOSError..forgeis a regular file → clean error.quality-manifesto.mdis a directory → clean "not a regular file" error.required=Truelegs (missing quality, missing testing).Test plan
PYTHONPATH=src pytest tests/test_manifestos_discover.py— 19 passed.PYTHONPATH=src pytest tests/test_manifestos_discover.py tests/test_manifestos_discovery.py— 41 passed (existing seed-manifesto tests unaffected).🤖 Generated with Claude Code