Skip to content

Corrects check modules names in config on startup #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Corrects check modules names in config on startup #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/haddock/gear/prepare_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ def setup_run(
params,
)

validate_module_names_are_not_misspelled(params)

# separate general from modules' parameters
_modules_keys = identify_modules(params)
general_params = remove_dict_keys(params, _modules_keys)
Expand All @@ -177,7 +179,6 @@ def setup_run(

general_params[RUNDIR] = extend_run

validate_module_names_are_not_misspelled(modules_params)
check_if_modules_are_installed(modules_params)
check_specific_validations(general_params)

Expand Down Expand Up @@ -549,7 +550,7 @@ def validate_module_names_are_not_misspelled(params):
matched = fuzzy_match([module_name], module_names)
emsg = (
f"Module {param_name!r} is not a valid module name,"
f" did you mean {matched[0][1]}?. "
f" did you mean {matched[0][1]!r}?. "
f"Valid modules are: {', '.join(module_names)}."
)
raise ValueError(emsg)
Expand Down