Skip to content

Implement water refinement (waterref) module #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2021
Merged

Implement water refinement (waterref) module #51

merged 3 commits into from
Jul 30, 2021

Conversation

@rvhonorato
Copy link
Member

This PR implements the core water refinement module.

(Carnaval) screenshot showing rigidbody (yellow), flexref(green) and waterref (magenta) results:

Screenshot 2021-07-30 at 14 13 01

@rvhonorato rvhonorato added the enhancement Improving something in the codebase label Jul 30, 2021
@rvhonorato rvhonorato self-assigned this Jul 30, 2021
amjjbonvin
amjjbonvin approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go over the scripts to simplify things once we are a bit further with the modules.

@rvhonorato rvhonorato merged commit 30dd3a5 into haddocking:main Jul 30, 2021
@rvhonorato rvhonorato deleted the waterref branch July 30, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amjjbonvin amjjbonvin amjjbonvin approved these changes

@joaomcteixeira joaomcteixeira Awaiting requested review from joaomcteixeira

Assignees

@rvhonorato rvhonorato

Labels

enhancement Improving something in the codebase

Projects

None yet

Milestone

v3.0.0 stable release

Development

Successfully merging this pull request may close these issues.

2 participants

@rvhonorato @amjjbonvin