Skip to content

Conversation

@VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Jun 8, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

In this PR, deprecation warning that are printed to user while running the command python3 setup.py develop --no-deps during the installation are silenced.
This is performed by the importation of the warning library and the two EasyInstallDeprecationWarning and SetuptoolsDeprecationWarning warning class from the setuptools library.

To compensate (and somehow remember) that these warnings exists, one line is added in the docs/INSTALL.md to justify the use of python setup.py.

(also related to #617)

@mgiulini mgiulini merged commit 5c901fb into main Aug 7, 2023
@mgiulini mgiulini deleted the install-warning branch August 7, 2023 10:15
@VGPReys VGPReys added the enhancement Improving something in the codebase label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving something in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants