Skip to content

Conversation

@prpeh
Copy link
Contributor

@prpeh prpeh commented Apr 7, 2025

No description provided.

@hadv hadv requested a review from Copilot April 7, 2025 06:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (6)

server/src/services/embedding.ts:92

  • [nitpick] Ensure that renaming from 'qdrantService' to 'qdrant' is consistent with the overall naming conventions of the project.
// This functionality is delegated to qdrant

server/src/routes/document.ts:4

  • Refactor the import path to match the new filename without the 'Controller' postfix as per the refactoring.
import * as documentController from '../controllers/documentController';

server/src/index.ts:6

  • Update the import to use the new filename without the 'Routes' postfix to maintain naming consistency.
import documentRoutes from './routes/documentRoutes';

server/src/core/database-service.ts:5

  • Change the import to use the updated module name without the 'Service' postfix for consistency.
import { createEmbedding } from '../services/embeddingService';

server/src/controllers/document.ts:3

  • Update the import to reflect the new filename without the 'Service' postfix for the embed creation functionality.
import { createEmbedding } from '../services/embeddingService';

server/src/controllers/document.ts:3

  • Modify the import path to remove the 'Service' postfix, ensuring consistency with the new naming convention.
import { parseDocument } from '../services/documentParserService';

@hadv hadv merged commit 3064a7f into hadv:master Apr 7, 2025
1 check passed
@prpeh prpeh deleted the refactor/remove-postfix-names branch April 7, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants