Add option for setting xhr.withCredentials#13
Merged
haeric merged 2 commits intohaeric:masterfrom Feb 20, 2020
Merged
Conversation
neilsot
commented
Feb 19, 2020
neilsot
commented
- Support for withCredentials already existed, there was just no way to set it
- Test cases might fail in Chrome 80+ due to httpbin cookie settings, see code comments
- Support for withCredentials already existed, there was just no way to set it - Test cases might fail in Chrome 80+ due to httpbin cookie settings, see code comments
neilsot
force-pushed
the
xhr-credentials
branch
from
70a5f5d to
dec8d07
Compare
Author
|
The quick force push was amending the commit message to remove my personal email address from a public repo. No spam please 😄 |
dbuck
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.