Conversation
- Move discord and sample_log modules into the consumer module.
- Print the warning when -o is ignored using eprintln! rather than warn! as it is called before the logging system is initialized. - Fix incorrect comparison when determining whether to show warning for max wav recording length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
songbird.discordmodule into a new top-levelconsumermodule.wavconsumer, which writes intercepted audio into a wav file. This consumer is available for production builds, but requires thewavfeature to be enabled (which it is by default). This replaces the previoussample_logconsumer.wavconsumer.Closes #14.