Fix: drain stale LOGOUT responses during login#19
Merged
halacs merged 1 commit intohalacs:masterfrom Apr 1, 2026
Merged
Conversation
The gateway sends a LOGOUT frame for each stale session before the actual LOGIN response. Previously, Login() would fail with "received unexpected packet" if a stale LOGOUT arrived first. Now drains up to 20 stale LOGOUT frames before processing the login response. Also extracts receiveResponse() as a reusable helper and simplifies transmitCommand() to use it.
halacs
reviewed
Apr 1, 2026
Owner
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway sends a LOGOUT frame for each stale session before the actual LOGIN response. Previously, Login() would fail with "received unexpected packet" if a stale LOGOUT arrived first (the existing TODO comment on line 345 of Client.go notes this issue).
This change drains up to 20 stale LOGOUT frames before processing the login response. Also extracts receiveResponse() as a reusable helper and simplifies transmitCommand() to use it.
Observed on a ProMatic 3 (firmware EE001425-14): stale sessions accumulate when connections are closed without sending LOGOUT (e.g. after crashes or network interruptions). The gateway then floods LOGOUTs on the next login attempt.
Thanks to @halacs for this project, which was essential for building my own garage door integration.