refactor: enhance type hints in diagnosis.py#24
Merged
Conversation
- Replace Any with proper recursive JSONValue type definition - Use cast() instead of type: ignore for type assertions - Add Protocol classes for better type safety - Improve function signatures with TypeVar - Reduce type: ignore comments from 7 to 2 The remaining 2 type: ignore comments are necessary for CPython internal functions not exposed in typeshed stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anywith proper recursiveJSONValuetype definitioncast()instead oftype: ignorefor type assertionsProtocolclasses for better type safetyTypeVartype: ignorecomments from 7 to 2Details
Changes Made
JSONValue Type Definition
JSONValue = Anyto a proper recursive type:Protocol Classes Added
_ParseError: Define exception interface_ExtendedDecoder: Define extended JSONDecoder interface_JsonDecoderModule: Define json.decoder module interfaceType Assertions
cast(_ExtendedDecoder, ...)instead of# type: ignore[assignment]cast(_ParseError, e)for exception handlingFunction Signatures
_record_parser_name: Now usesTypeVarfor better type inferenceTest Plan
mypychecks passruffchecks passNotes
The remaining 2
type: ignorecomments are necessary for CPython internalfunctions (
py_scanstring,py_make_scanner) not exposed in typeshed stubs.