Merged
Conversation
halfbyte
requested changes
Apr 15, 2026
Owner
halfbyte
left a comment
halfbyte
left a comment
There was a problem hiding this comment.
Hi. Thanks for the PR, this looks good, I have two small changes I'd like you to make.
|
|
||
| module Secretariat | ||
| VERSION = "3.8.1" | ||
| VERSION = "3.8.2" |
Owner
There was a problem hiding this comment.
Please remove this change. Incrementing version numbers happens during the release process.
| assert_match(/<ram:ExemptionReason>Reverse Charge<\/ram:ExemptionReason>/, xml) | ||
| assert_match(/<ram:RateApplicablePercent>/, xml) | ||
| assert_match(%r{<ram:BuyerTradeParty>\s*<ram:ID>Kunde 4711</ram:ID>}, xml) | ||
| assert_equal xml.include?('<ram:Reason>'), false |
Owner
There was a problem hiding this comment.
I think I would prefer refute xml.include?('<ram:Reason>') or even a refute_match` here.
valii2334
force-pushed
the
omit_discout_reason_if_blank
branch
from
f0fab50 to
d466951
Compare
halfbyte
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some validators throw a warning if discount_reason is blank.
We shouldn't add it if it's blank.