Skip to content

Fix lossless_cast test on WASM#8949

Merged
abadams merged 2 commits intomainfrom
alexreinking/fix-lossless-cast
Feb 17, 2026
Merged

Fix lossless_cast test on WASM#8949
abadams merged 2 commits intomainfrom
alexreinking/fix-lossless-cast

Conversation

@alexreinking
Copy link
Member

The correctness_lossless_cast failed on WASM in #8948 during fuzzing with the following LLVM internal assertion error:

correctness_lossless_cast: /__w/llvm-wheel/llvm-wheel/src_cache/main/llvm/include/llvm/Support/Casting.h:560: decltype(auto) llvm::cast(const From&) [with To = LoadSDNode; From = SDValue]: Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"' failed.

Unfortunately, the seed was not flushed to stdout prior to the failure. This PR is intended to improve error reporting in this case and, ideally, reproduce and fix the error.

@alexreinking
Copy link
Member Author

correctness_oddly_sized_output failed randomly on x86-32-windows (T=x86-32-windows) but the reason why is unclear. Entering the buildbot and manually running the test yields simply "Success!"

@alexreinking alexreinking marked this pull request as ready for review February 16, 2026 14:53
@alexreinking alexreinking requested a review from abadams February 16, 2026 14:53
@alexreinking
Copy link
Member Author

We couldn't reproduce the failure here, but there's no downside to merging a "flush the seed" patch.

@abadams abadams merged commit 303bf2b into main Feb 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants