Upgrade halide-llvm to 23.0.0.dev82675+gf912679b#8959
Merged
alexreinking merged 4 commits intomainfrom Feb 24, 2026
Merged
Conversation
Member
|
Fixing Injected here: llvm/llvm-project#137643 |
PIC is meaningless on Windows. Position independence is handled by the PE/COFF linker via base relocations, not by the compiler via GOT/PLT. See: llvm/llvm-project#137643
alexreinking
requested review from
halidebuildbots
and removed request for
halidebuildbots
Member
|
Might need to narrow the PIC change to win32. Investigating... |
Comment on lines
+5094
to
+5102
| // PIC is meaningless on 32-bit Windows. Position independence is handled | ||
| // by the PE/COFF linker via base relocations, not by the compiler via | ||
| // GOT/PLT. On 64-bit Windows, Reloc::PIC_ causes LLVM to emit RIP-relative | ||
| // addressing which avoids ADDR32 relocations that are incompatible | ||
| // with /LARGEADDRESSAWARE. | ||
| // See: https://github.com/llvm/llvm-project/pull/137643 | ||
| if (target.os == Target::Windows && target.bits == 32) { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
This can be reverted if/when llvm/llvm-project#182903 lands
Member
|
Only failure is due to the rotten V8 backend. Opened #8961 to fix it. |
abadams
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upgrade via
uv lock -P halide-llvm.