Skip to content

Refactor CI workflows and improve test configuration#9010

Merged
alexreinking merged 13 commits into
mainfrom
alexreinking/testing-cleanup
Mar 12, 2026
Merged

Refactor CI workflows and improve test configuration#9010
alexreinking merged 13 commits into
mainfrom
alexreinking/testing-cleanup

Conversation

@alexreinking
Copy link
Copy Markdown
Member

This PR bundles a few changes together (to avoid spending a bunch of CI time these changes are all designed to reduce)

  • We skip simd_op_check builds on non-host targets
  • We move scattered autoscheduler tests to tests/ (this might be slightly broken; we'll see what CI says. I tested it to work locally, though)
  • The GHA workflow steps have been grouped by path-relevance. That way we don't run tests that couldn't possibly fail for a code-related reason.

Fixes #9009
Fixes #9004

@alexreinking alexreinking added build Issues related to building Halide and with CI code_cleanup No functional changes. Reformatting, reorganizing, or refactoring existing code. labels Mar 11, 2026

# Simd op check tests fix the target features internally, so they
# only need to be run on one target in CI. Every CI runner targets
# host, so we can just check for that.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If every runner targets host, then every runner will simd op check all targets ? Wasn't the goal to not do it redundantly ?

This could be stripped further down to every machine just testing its own architectures op check suite.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we wanted to make sure cross-compilation worked. But maybe we have enough coverage elsewhere. I'd like @abadams to weigh in

Comment thread src/autoschedulers/anderson2021/LoopNest.cpp
Comment thread test/correctness/CMakeLists.txt
Copy link
Copy Markdown
Contributor

@shoaibkamil shoaibkamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except not sure about change in one of the autoscheduler sources. See my comment

@alexreinking
Copy link
Copy Markdown
Member Author

win-worker-3 is timing out on halide_as_onnx_backend_test (which is very heavy). Will investigate in a follow-up PR.

@alexreinking alexreinking merged commit d5ec0bb into main Mar 12, 2026
24 of 25 checks passed
@alexreinking alexreinking deleted the alexreinking/testing-cleanup branch March 12, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues related to building Halide and with CI code_cleanup No functional changes. Reformatting, reorganizing, or refactoring existing code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GHA workflows need better filters There is no reason to run simd_op_check so much

3 participants