Add workflow to check CMake against Ubuntu-provided dependencies#9016
Merged
Conversation
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
…vided dependencies
shoaibkamil
reviewed
Mar 13, 2026
| NAMES flatbuffers Flatbuffers FlatBuffers | ||
| ) | ||
| _Halide_pkgdep(flatbuffers) | ||
| find_package(FlatBuffers REQUIRED) |
Contributor
There was a problem hiding this comment.
No longer setting a minimum version?
Member
Author
There was a problem hiding this comment.
@abadams tested it to work as far back as 2.0.8, so their API has been very stable in practice. This is a little worse for catching mistakes arising from mixing versions across other projects, but I think this is outweighed by the flexibility we get in return.
shoaibkamil
approved these changes
Mar 13, 2026
Contributor
shoaibkamil
left a comment
shoaibkamil
left a comment
There was a problem hiding this comment.
Small nit, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to force vcpkg on our users, and @abadams noticed that our CMake configuration rejects the versions of flatbuffers and wabt that comes with Ubuntu 24.04. This workflow should ensure we don't regress.
Unfortunately, while flatbuffers 2.0.8 appears to work, wabt 1.0.36 is a bit broken: it's missing a dependency on
libssl-devand is not built with-fPIC, so we can't link to it. The newubuntu-*presets disable the wasm backend by default to account for this.