Skip to content

Remove unnecessary output files in simd_op_check#9131

Merged
alexreinking merged 1 commit into
halide:mainfrom
stevesuzuki-arm:pr-rm_outputs_simd_op_check
May 12, 2026
Merged

Remove unnecessary output files in simd_op_check#9131
alexreinking merged 1 commit into
halide:mainfrom
stevesuzuki-arm:pr-rm_outputs_simd_op_check

Conversation

@stevesuzuki-arm
Copy link
Copy Markdown
Contributor

Fixes #9130

  • Tests added or updated (not required for docs, CI config, or typo fixes)

@stevesuzuki-arm
Copy link
Copy Markdown
Contributor Author

Note llvm_assembly is kept as it seems to be deliberately added by @mcourteaux just a couple of months ago.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@958de4a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9131   +/-   ##
=======================================
  Coverage        ?   69.68%           
=======================================
  Files           ?      255           
  Lines           ?    77695           
  Branches        ?    18545           
=======================================
  Hits            ?    54138           
  Misses          ?    18004           
  Partials        ?     5553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexreinking alexreinking merged commit af9c016 into halide:main May 12, 2026
20 of 21 checks passed
@mcourteaux
Copy link
Copy Markdown
Contributor

I was debugging codegen issues I caught by narrowing down the search for the instruction of interest in the op_check. We had just one bug, but inspecting the LLVM assembly was useful at that point. For everyday testing purposes that can also be disabled. Perhaps some sort of verbosity/debugging flag for the simd_op_check is good, if we don't want to just comment this line? @alexreinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simd_op_check produces the files which do not look essential

3 participants