Remove unnecessary output files in simd_op_check#9131
Merged
alexreinking merged 1 commit intoMay 12, 2026
Conversation
Contributor
Author
|
Note llvm_assembly is kept as it seems to be deliberately added by @mcourteaux just a couple of months ago. |
mcourteaux
approved these changes
May 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
=======================================
Coverage ? 69.68%
=======================================
Files ? 255
Lines ? 77695
Branches ? 18545
=======================================
Hits ? 54138
Misses ? 18004
Partials ? 5553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I was debugging codegen issues I caught by narrowing down the search for the instruction of interest in the op_check. We had just one bug, but inspecting the LLVM assembly was useful at that point. For everyday testing purposes that can also be disabled. Perhaps some sort of verbosity/debugging flag for the simd_op_check is good, if we don't want to just comment this line? @alexreinking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9130