Fix two developer-facing annoyances#9133
Merged
Merged
Conversation
Using plain `python` requires an active virtual environment, but our pre-commit Python scripts don't have any dependencies. It's safe to just use any old python3 that's in the PATH.
Member
Author
|
Running buildbots to make sure I didn't inadvertently break the vcpkg configuration. |
abadams
approved these changes
May 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9133 +/- ##
=======================================
Coverage ? 69.77%
=======================================
Files ? 255
Lines ? 77531
Branches ? 18538
=======================================
Hits ? 54094
Misses ? 17949
Partials ? 5488 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things have been bothering me for a while:
pythoninstead ofpython3in the custom pre-commit commands. These require an active virtual environment, which is annoying when you aren't working on anything Python-related and are using system dependencies.cmake/vcpkgfolder is inconsistent withcmake/vcpkg-tripletsand a little misleading in that it sounds like a submodule checkout of vcpkg. Rename that tocmake/vcpkg-portsto indicate that it contains ports.Checklist