Skip to content

Fix two developer-facing annoyances#9133

Merged
alexreinking merged 2 commits into
mainfrom
alexreinking/tweaks
May 12, 2026
Merged

Fix two developer-facing annoyances#9133
alexreinking merged 2 commits into
mainfrom
alexreinking/tweaks

Conversation

@alexreinking
Copy link
Copy Markdown
Member

Two small things have been bothering me for a while:

  1. I used python instead of python3 in the custom pre-commit commands. These require an active virtual environment, which is annoying when you aren't working on anything Python-related and are using system dependencies.
  2. The naming of the cmake/vcpkg folder is inconsistent with cmake/vcpkg-triplets and a little misleading in that it sounds like a submodule checkout of vcpkg. Rename that to cmake/vcpkg-ports to indicate that it contains ports.

Checklist

  • Documentation updated (if public API changed)
  • Commits include AI attribution where applicable (see Code of Conduct)

Using plain `python` requires an active virtual environment,
but our pre-commit Python scripts don't have any dependencies.
It's safe to just use any old python3 that's in the PATH.
@alexreinking alexreinking requested a review from abadams May 12, 2026 16:25
@alexreinking alexreinking changed the title Alexreinking/tweaks Fix two developer-facing annoyances May 12, 2026
@alexreinking
Copy link
Copy Markdown
Member Author

Running buildbots to make sure I didn't inadvertently break the vcpkg configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@2834ffe). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9133   +/-   ##
=======================================
  Coverage        ?   69.77%           
=======================================
  Files           ?      255           
  Lines           ?    77531           
  Branches        ?    18538           
=======================================
  Hits            ?    54094           
  Misses          ?    17949           
  Partials        ?     5488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexreinking alexreinking merged commit 66c7898 into main May 12, 2026
24 of 26 checks passed
@alexreinking alexreinking deleted the alexreinking/tweaks branch May 13, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants