Fix Makefile dep so autoscheduler plugins re-cp into distrib#9136
Merged
Conversation
The libHalide.so distrib rule runs `rm -rf $(DISTRIB_DIR)` before repopulating, which deletes the previously-copied autoscheduler plugins. Make decides up-front whether the plugin distrib targets need rebuilding, so it doesn't notice the deletion. The mullapudi2016 and li2018 sub-makes treat libHalide as order-only, so their bin/ files don't refresh either, leaving distrib missing those two plugins until a second `make distrib`. Add libHalide.so as a prereq of the plugin distrib rule so the cp re-fires whenever libHalide is rebuilt. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alexreinking
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libHalide.so distrib rule runs
rm -rf $(DISTRIB_DIR)before repopulating, which deletes the previously-copied autoscheduler plugins. Make decides up-front whether the plugin distrib targets need rebuilding, so it doesn't notice the deletion. The mullapudi2016 and li2018 sub-makes treat libHalide as order-only, so their bin/ files don't refresh either, leaving distrib missing those two plugins until a secondmake distrib.Add libHalide.so as a prereq of the plugin distrib rule so the cp re-fires whenever libHalide is rebuilt.
This fixes a makefile bug where you have to run "make distrib" twice on any change.