Merged
Conversation
added 5 commits
March 2, 2026 15:36
# Conflicts: # src/Command/Extract.php # src/Extractor/ConfluenceExtractor.php
# Conflicts: # src/Analyzer/ConfluenceAnalyzer.php # src/Analyzer/Processor/BodyContents.php # src/Composer/ConfluenceComposer.php # src/Converter/ConfluenceConverter.php # src/Extractor/ConfluenceExtractor.php # tests/phpunit/Analyzer/Processor/BodyContents/BodyContentsTest.php
… verification - Add ConfluenceUserImpl, Comment, and BodyContent objects to the source fixture so the full comment pipeline path is exercised - Fix runExtract() bucket list: add global-body-content-id-to-comment-id-map - Fix runCompose() bucket list: add global-page-id-to-comment-ids-map, global-comment-id-to-metadata-map, global-page-id-to-title-map, global-userkey-to-username-map - Assert that result/comments.xml is generated and matches external_image_url_export_result_comments.xml - Add external_image_url_export_result_comments.xml fixture with expected Talk page containing cs-comments JSON slot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DvogelHallowelt
requested changes
Mar 19, 2026
added 3 commits
March 19, 2026 11:40
# Conflicts: # src/Analyzer/ConfluenceAnalyzer.php # src/Converter/ConfluenceConverter.php # tests/phpunit/Analyzer/Processor/BodyContents/BodyContentsTest.php # tests/phpunit/FullMigrationTest.php # tests/phpunit/data/FullMigration/export_source.xml
DvogelHallowelt
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERM46627