Use space key instead of space id for broken links because space id m…#200
Merged
danielriedmueller merged 4 commits intomainfrom Mar 31, 2026
Merged
Use space key instead of space id for broken links because space id m…#200danielriedmueller merged 4 commits intomainfrom
danielriedmueller merged 4 commits intomainfrom
Conversation
| private function ensureSpaceId( DOMNode $node ): int { | ||
| $spaceId = $this->currentSpaceId; | ||
| $spaceKey = $node->getAttribute( 'ri:space-key' ); | ||
| $this->spaceKey = ''; |
Contributor
There was a problem hiding this comment.
$this->spaceKey shouldnt be set here. its immediately overwritten and this should be a pure function which doesnt just change this global variable. here its set to empty string and if there is no ri:space-key attribute, in generateConfluenceKey on line 98 its used and leads to wrong key
Contributor
There was a problem hiding this comment.
the same is in ImagePageLinkHelper
danielriedmueller
requested changes
Mar 30, 2026
danielriedmueller
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ay only be -1