Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

refactor: load the theme and plugin logos using the avatar component#657

Merged
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
ruibaby:refactor/plugin-logo
Oct 24, 2022
Merged

refactor: load the theme and plugin logos using the avatar component#657
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
ruibaby:refactor/plugin-logo

Conversation

@ruibaby
Copy link
Copy Markdown
Member

@ruibaby ruibaby commented Oct 23, 2022

What type of PR is this?

/kind improvement
/milestone 2.0

What this PR does / why we need it:

插件和主题管理的 Logo 改为使用 Avatar 组件。

Special notes for your reviewer:

/cc @halo-dev/sig-halo-console

测试方式:检查主题和插件相关的管理页面是否正常加载 Logo。

Does this PR introduce a user-facing change?

插件和主题管理的 Logo 改为使用 `Avatar` 组件。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 23, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 23, 2022
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 23, 2022
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 23, 2022

@ruibaby is attempting to deploy a commit to the halo-dev Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
halo-admin-next ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 3:16AM (UTC)
halo-admin-ui ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 3:16AM (UTC)

Copy link
Copy Markdown
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2022
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit f77ec61 into halo-dev:main Oct 24, 2022
@ruibaby ruibaby deleted the refactor/plugin-logo branch October 24, 2022 03:20
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…alo-dev/console#657)

#### What type of PR is this?

/kind improvement
/milestone 2.0

#### What this PR does / why we need it:

插件和主题管理的 Logo 改为使用 `Avatar` 组件。

#### Special notes for your reviewer:

/cc @halo-dev/sig-halo-console 

测试方式:检查主题和插件相关的管理页面是否正常加载 Logo。

#### Does this PR introduce a user-facing change?

```release-note
插件和主题管理的 Logo 改为使用 `Avatar` 组件。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants