add css for multi root elements #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # dist/halower-tree.min.css # dist/v2-tree.js # dist/v2-tree.js.map # src/components/tree.vue
halower
reviewed
Jan 25, 2018
src/components/tree.vue
Outdated
| if (typeof newNode === 'string') { | ||
| addnode = {title: newNode} | ||
| addnode = { | ||
| id: (Math.random().toString(36)+'00000000000000000').slice(2, 7), // Generate random id of 5 characters |
There was a problem hiding this comment.
if u use a random id, then no initialization ID how to deal with?
There was a problem hiding this comment.
if the ID may exist may not exist, then the existence of id here is what is the meaning?
There was a problem hiding this comment.
I tend to the user's own incoming ID， and you
|
Sorry, this pull request include also the generation of ID. I will made a brand new pull request with only che CSS part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made a small change to the css to display multi root elements correctly.
Thanks for this great components!
Matteo