fix(config): remove "use client" directive to fix ui-core build#192
Merged
halvaradop merged 1 commit intomasterfrom Jun 30, 2025
Merged
fix(config): remove "use client" directive to fix ui-core build#192halvaradop merged 1 commit intomasterfrom
"use client" directive to fix ui-core build#192halvaradop merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
"use client"directive from the@halvaradop/ui-corepackage. Including this directive at the top level of the package was causing rendering issues in applications using Server Components—particularly in Next.js—because it forces the file to be treated as a Client Component, preventing its usage in server-rendered environments.This issue was identified while integrating the library into a Next.js project, which distinguishes between client and server components using
"use client"and"use server"directives.By removing the directive, we restore compatibility with server-side rendering (SSR) and allow developers to apply
"use client"only where needed in their own application code.Checklist
Notes