Skip to content

Minor problem in Variant.__init__#119

Merged
iskandr merged 3 commits intomasterfrom
fix-variant-start-and-string-reference
Aug 28, 2015
Merged

Minor problem in Variant.__init__#119
iskandr merged 3 commits intomasterfrom
fix-variant-start-and-string-reference

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Aug 28, 2015

The "fast" path for initializing a Variant object didn't convert the start parameter to an int. Also added support for creating the variant's associated genome from the string name of a reference.

Review on Reviewable

…art property to int and couldn't handle a reference name for its ensembl arg
@tavinathanson
Copy link
Copy Markdown
Contributor

If we're letting a Genome be an int release or a str reference_name, we might as well do the same in load_vcf so that @timodonnell's release_num code doesn't break?

Offline discussion: the load_vcf genome argument can just be passed through to Variant?

@tavinathanson
Copy link
Copy Markdown
Contributor

iskandr added a commit that referenced this pull request Aug 28, 2015
…eference

Minor problem in Variant.__init__
@iskandr iskandr merged commit 97560ba into master Aug 28, 2015
@iskandr iskandr deleted the fix-variant-start-and-string-reference branch August 28, 2015 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants