Skip to content

added IntronicSpliceSite, SpliceDonor, SpliceAcceptor effects#17

Merged
iskandr merged 3 commits intomasterfrom
intronic_splicing_effects
Feb 19, 2015
Merged

added IntronicSpliceSite, SpliceDonor, SpliceAcceptor effects#17
iskandr merged 3 commits intomasterfrom
intronic_splicing_effects

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Feb 18, 2015

No description provided.

@iskandr
Copy link
Copy Markdown
Contributor Author

iskandr commented Feb 18, 2015

Fixes #16 and partially fixes #1 (still need to support exonic splice variants)

Comment thread varcode/core_logic.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best_distance, best_exon ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. I think this calls for a unit test or two.

@timodonnell
Copy link
Copy Markdown
Contributor

module comments LGTM

@iskandr
Copy link
Copy Markdown
Contributor Author

iskandr commented Feb 18, 2015

I moved find_nearest_exon into PyEnsembl, see: openvax/pyensembl#39

iskandr added a commit that referenced this pull request Feb 19, 2015
added IntronicSpliceSite, SpliceDonor, SpliceAcceptor effects
@iskandr iskandr merged commit 54fc368 into master Feb 19, 2015
@iskandr iskandr deleted the intronic_splicing_effects branch February 19, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants