Merged
Conversation
…ing transcript.protein_sequence instead of translating
…has special faster case for SNVs
Contributor
There was a problem hiding this comment.
might as well assert this?
Contributor
Author
There was a problem hiding this comment.
Asserting in a second branch that does refactoring on top of this.
Contributor
|
LGTM. I like the random variant annotation testing! |
iskandr
added a commit
that referenced
this pull request
Mar 27, 2015
Use transcript protein sequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall motivation: move toward translating as few codons as necessary for each annotation (instead of always translating the full original & mutated proteins)
transcript.protein_sequenceinstead of translating original proteincoding_effect(plan to generalize this as a cleaner logic for all in-frame coding effects), translates only single affected codon