Skip to content

Created EpitopeCollection, refactored effects, fix assertion failure while annotating silent stop codon#66

Merged
iskandr merged 11 commits intomasterfrom
fix-silent-stop-codon-variants
Apr 24, 2015
Merged

Created EpitopeCollection, refactored effects, fix assertion failure while annotating silent stop codon#66
iskandr merged 11 commits intomasterfrom
fix-silent-stop-codon-variants

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Apr 24, 2015

Created an EffectCollection, which is used for filtering and grouping sets of effects.
VariantCollection.effects() now returns an EffectCollection.
Merged functionality of top_effect() and highest_priority_effects into EffectCollection.top_priority_effect()
Created a base class Collection from which VariantCollection and EffectCollection get their simpler methods like __iter__ and __len__
Simplified the effect hierarchy, expanded the ambiguous aa_pos (which means slightly different things for different effect types), into the more explicit aa_mutation_start_offset and aa_mutation_end_offset.

Fixes #64 and #58, #63

Review on Reviewable

@iskandr iskandr force-pushed the fix-silent-stop-codon-variants branch from c78e518 to e76d5c9 Compare April 24, 2015 03:16
…nning of inframe effect logic, checking to make sure insertions after an exon don't get counted as part of the exon
Comment thread varcode/variant_collection.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a list comprehension?

@arahuja
Copy link
Copy Markdown
Contributor

arahuja commented Apr 24, 2015

This looks good to me overall, though prob worth someone else scanning through as well @tavinathanson @timodonnell

Two general things seem odd to me:

  1. effect __lt__, sorting the effect by the variant might make sense in some cases, but I'm not sure that is always the expected ordering, especially when effects are usually sorted by some priority?
  2. The start_offset on Silent is a bit weird, since it creates a nonsense interval, and the start_offset is inclusive in every case but that.

@iskandr iskandr changed the title Fix assertion failure while annotating silent stop codon variants Created EpitopeCollection, refactored effects, fix assertion failure while annotating silent stop codon Apr 24, 2015
@iskandr
Copy link
Copy Markdown
Contributor Author

iskandr commented Apr 24, 2015

@arahuja Do you think the effects should be sorted by priority instead?

@iskandr iskandr merged commit ae8d367 into master Apr 24, 2015
@iskandr iskandr deleted the fix-silent-stop-codon-variants branch April 24, 2015 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modifies_coding_sequence is always false

2 participants