Conversation
…llection by getting rid of EffectColleciton.variants
…ase class Collection
c78e518 to
e76d5c9
Compare
…nning of inframe effect logic, checking to make sure insertions after an exon don't get counted as part of the exon
Contributor
There was a problem hiding this comment.
Just a list comprehension?
Contributor
|
This looks good to me overall, though prob worth someone else scanning through as well @tavinathanson @timodonnell Two general things seem odd to me:
|
Contributor
Author
|
@arahuja Do you think the effects should be sorted by priority instead? |
This was referenced Apr 29, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created an EffectCollection, which is used for filtering and grouping sets of effects.
VariantCollection.effects() now returns an EffectCollection.
Merged functionality of top_effect() and highest_priority_effects into EffectCollection.top_priority_effect()
Created a base class Collection from which VariantCollection and EffectCollection get their simpler methods like
__iter__and__len__Simplified the effect hierarchy, expanded the ambiguous aa_pos (which means slightly different things for different effect types), into the more explicit aa_mutation_start_offset and aa_mutation_end_offset.
Fixes #64 and #58, #63