Merged
Conversation
There was a problem hiding this comment.
I'd imagine you're doing this instead of using itertools.group_by because that one returns generators instead of lists? As an aside, this is a great place to use a collections.defaultdictionary.
Contributor
Author
There was a problem hiding this comment.
-
Yep, I didn't want the small annoyance of converting the iterator to a dictionary at the call site.
-
Good point about
defaultdict!
Contributor
|
having never looked at this code before, I'm not sure if my feedback is very helpful, but besides my small nit comments, lgtm |
…r_effects function into VariantAnnotator, shorter string representations for effects
…into own module, switched to Python3 friendly printing in VariantCollection
iskandr
force-pushed
the
refactor_core_logic
branch
from
6a93ea5 to
013009e
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.