Merged
Conversation
Adds support for serializing Variant instances as pickle or JSON. Closes #77.
Contributor
There was a problem hiding this comment.
Nitpick, but I don't think you need the extra parens around the function call, PEP8 seems pretty happy with arguments on the next line: http://legacy.python.org/dev/peps/pep-0008/#indentation
Contributor
Author
There was a problem hiding this comment.
Gotcha, the actual reason for that change was that the line was 80 chars, which my sublime pep8 plugin was complaining about (it wants <= 79 chars).
Contributor
|
Other than a few questions, LGTM. |
timodonnell
added a commit
that referenced
this pull request
Apr 30, 2015
…able Variant serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for serializing Variant instances as pickle or JSON.
Closes #77.