Speed up PileupCollection.group_by_allele#79
Merged
timodonnell merged 1 commit intomasterfrom May 1, 2015
Merged
Conversation
A loop in this function was accidentally running in time proportional to the total number of reads in the collection. This fix speeds up this function to an embarassing extent (over 1000X in my use case).
Contributor
|
LGTM and I'm really happy |
timodonnell
added a commit
that referenced
this pull request
May 1, 2015
Speed up PileupCollection.group_by_allele
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A loop in this function was accidentally running in time proportional to the total number of reads in the collection. This fix speeds up this function to an embarassing extent (over 1000X in my use case).