Support for regular varcode variant instances in read evidence module#87
Conversation
|
Mind taking a quick perusal of this, @tavinathanson ? |
There was a problem hiding this comment.
Nit: maybe mark this with TODO for easy discovery of TODOs (I should probably put this suggestion in the wiki)
|
@timodonnell I'm somewhat confused by the Update: Ah, I'm now looking at https://github.com/hammerlab/ovarian-cancer/blob/53c92e7ddc0b81b0864c7d28fd112c75c8747472/projects/pt189/read_evidence_plot.py to get a feel for usage. |
There was a problem hiding this comment.
I'm confused about why variant and locus are combined here?
(In general, I feel like x_or_y isn't good practice, but I don't yet understand why the code wants this in the first place.)
…iant-instances-in-read-evidence Support for regular varcode variant instances in read evidence module
The read evidence module has been in an awkward place since it uses a different
Variantclass than the rest of varcode, as it uses interbase coordinates whereas the rest of varcode uses 1-based coordinates. (Varcode will eventually migrate entirely to interbase; see #40). This change makes this situation mildly less annoying by having the read evidence module take care of converting regular varcodeVariantinstances to the needed interase format.