Issue 17 - add flag to disable danger check#18
Conversation
|
Taking a look now. The code changes seem fine to me. Instead of the poetry lock, could you revert that change and just change the pyproject.toml instead? |
|
@jfelten is there anything else I can help with? Let me know and I'll be ready to merge soon |
|
@handrew sorry for the delay - Did testing on my own scripts and it seems to work. There are some problems though with the examples. Only about half of them work with gpt-4. I'm not sure if you want to address that here or not Also I used gpt-4 for the instruction compiler vs gpt-4o-mini. The cost is significantly higher, but it is less error-prone. Overall I find this very useful and hope to contribute more. |
|
Hi, apologies for the delay on my end. Been pretty busy. I think everything looks good to me except the |
|
ok let me check - I forget which lib needed updating |
|
I reverted the poetry.lock file and bumped the patch version in pyproject.toml. The poetry.lock file was regenerated because poetry install failed. |
|
Wait but which of the dependencies needed updating? |
|
ok I ran poetry update then updated the dependencies in pyproject.yaml to the versions specified. |
|
may want to consider adding a .gitignore for the lock file |
|
thank you! try to merge by this weekend, and yes, good call, will ignore the lock file from now on... |
|
Merging, but will make a few changes before I actually push to pypi. |
|
@jfelten I removed the danger checking from InstructionCompiler entirely. It's only in GPTSeleniumAgent now. It is now available in pypi, version 0.2.53. Hope it works for you, and doesn't break anything for anyone else... |
Added flag to seleium agent class to disable security checking.
Update dependency libs