Skip to content

Issue 17 - add flag to disable danger check#18

Merged
handrew merged 5 commits into
handrew:mainfrom
jfelten:issue-17
Dec 21, 2024
Merged

Issue 17 - add flag to disable danger check#18
handrew merged 5 commits into
handrew:mainfrom
jfelten:issue-17

Conversation

@jfelten
Copy link
Copy Markdown

@jfelten jfelten commented Nov 13, 2024

Added flag to seleium agent class to disable security checking.

Update dependency libs

@handrew
Copy link
Copy Markdown
Owner

handrew commented Nov 14, 2024

Taking a look now. The code changes seem fine to me. Instead of the poetry lock, could you revert that change and just change the pyproject.toml instead?

@handrew
Copy link
Copy Markdown
Owner

handrew commented Nov 15, 2024

@jfelten is there anything else I can help with? Let me know and I'll be ready to merge soon

@jfelten jfelten marked this pull request as ready for review November 18, 2024 06:50
@jfelten
Copy link
Copy Markdown
Author

jfelten commented Nov 18, 2024

@handrew sorry for the delay - Did testing on my own scripts and it seems to work. There are some problems though with the examples. Only about half of them work with gpt-4. I'm not sure if you want to address that here or not

Also I used gpt-4 for the instruction compiler vs gpt-4o-mini. The cost is significantly higher, but it is less error-prone.

Overall I find this very useful and hope to contribute more.

@handrew
Copy link
Copy Markdown
Owner

handrew commented Nov 21, 2024

Hi, apologies for the delay on my end. Been pretty busy. I think everything looks good to me except the poetry.lock—can you revert that change and just make changes to the pyproject.toml instead? Once you do that I can merge.

@jfelten
Copy link
Copy Markdown
Author

jfelten commented Nov 22, 2024

ok let me check - I forget which lib needed updating

@jfelten
Copy link
Copy Markdown
Author

jfelten commented Nov 22, 2024

I reverted the poetry.lock file and bumped the patch version in pyproject.toml. The poetry.lock file was regenerated because poetry install failed.

@handrew
Copy link
Copy Markdown
Owner

handrew commented Nov 22, 2024

Wait but which of the dependencies needed updating?

@jfelten
Copy link
Copy Markdown
Author

jfelten commented Nov 22, 2024

ok I ran poetry update then updated the dependencies in pyproject.yaml to the versions specified.

@jfelten
Copy link
Copy Markdown
Author

jfelten commented Nov 22, 2024

may want to consider adding a .gitignore for the lock file

@handrew
Copy link
Copy Markdown
Owner

handrew commented Nov 22, 2024

thank you! try to merge by this weekend, and yes, good call, will ignore the lock file from now on...

@handrew handrew merged commit e2c12c6 into handrew:main Dec 21, 2024
@handrew
Copy link
Copy Markdown
Owner

handrew commented Dec 21, 2024

Merging, but will make a few changes before I actually push to pypi.

@handrew
Copy link
Copy Markdown
Owner

handrew commented Dec 21, 2024

@jfelten I removed the danger checking from InstructionCompiler entirely. It's only in GPTSeleniumAgent now.

It is now available in pypi, version 0.2.53. Hope it works for you, and doesn't break anything for anyone else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants